227

They can see the policy working... (lemmy.sdf.org)

submitted 2 weeks ago by xia@lemmy.sdf.org to c/programmer_humor@programming.dev

24 comments fedilink hide all child comments

top 24 comments

sorted by: hot top controversial new old

[-] masterspace@lemmy.ca 59 points 2 weeks ago

We have linting set up in our codebase, I had to switch and focus on one half of our project, and I nearly lost my mind when I came back to the other side and realized that every time someone said they were 'addressing linting issues', that actually meant they were putting eslint-disable everywhere until the pipeline stopped complaining.

[-] magikmw@lemm.ee 5 points 1 week ago

I might get physical in that sitiation. And I'm very tame.

[-] savvywolf@pawb.social 51 points 2 weeks ago

Hot take: Clean up your darn imports. Otherwise you just make the links between modules confusing and messy.

[-] jadelord@discuss.tchncs.de 13 points 1 week ago

Sounds like a perfectly normal take.

[-] CanadaPlus@lemmy.sdf.org 9 points 1 week ago

Really, OP might have had the hot one with "unnecessary imports sitting around is fine".

[-] shynoise@lemmy.world 3 points 1 week ago

...if only that were the case.

[-] CanadaPlus@lemmy.sdf.org 19 points 2 weeks ago

The duality of Programmer Humor: You get posts complaining about bloat, and posts complaining about this.

[-] xia@lemmy.sdf.org 26 points 1 week ago

[-] katze@lemmy.cafe 5 points 1 week ago

Competent people vs incompetent people.

[-] Quetzalcutlass@lemmy.world 11 points 2 weeks ago

Except those imports were used by a huge section of code you temporarily commented out, and now you'll need to manually select a dozen imports to get it working again when you come back to it.

(Sure you could have just commented out the unused imports, but the linter auto-sorted them and you're feeling too lazy to copy-paste a dozen scattered lines)

[-] blaue_Fledermaus@mstdn.io 31 points 2 weeks ago

That is what version control is for.

[-] entropicdrift@lemmy.sdf.org 21 points 2 weeks ago

This. Commenting out code is bad practice

[-] naeap@sopuli.xyz 2 points 2 weeks ago

In general, I'm with you
But sometimes I need to revert/comment out a code block, because another code part isn't finished/working as it should.
Sure, it clutters code, but if I just comment out a function call and temporarily replace it with the workaround, it should imho stay in code.

Else the workaround will stay forever and the commented out code will act as a reminder, that this part isn't clean yet.

But maybe it really is a case by case thing, where sometimes it's better to branch it out for later merge - although that can get really messy, while having the future implementation commented out, others will also see, how it is supposed to work and don't try to further extend the workaround, which makes future merging hell

Out of interest, how would your best practice look in such cases?

[-] entropicdrift@lemmy.sdf.org 4 points 1 week ago* (last edited 1 week ago)

I would make it a TODO so that it's clearly temporary and so the linter bugs me about it until the intended permanent code is restored.

In general I prefer to keep separate branches and maybe a draft PR open for visibility for that kind of situation, though.

[-] CameronDev@programming.dev 12 points 2 weeks ago

Use a good IDE, and readding the imports is pretty easy.

I find commented code to be a bit of a smell on its own, just delete it, and if you really need it again, dig it out of source control.

[-] jjjalljs@ttrpg.network 9 points 2 weeks ago

Yeah. My last job, a PR with commented out code typically wouldn't get approved. Either leave it in version history, or stick it on a branch

[-] mmddmm@lemm.ee 5 points 2 weeks ago

Hum... Ignore linter advice for code that you temporarily mangled.

It's not like you have to act upon it as soon as a blue line appears under your code.

[-] bleistift2@sopuli.xyz 0 points 2 weeks ago

Depending on the configuration, a linter may cause the compilation or a CI pipeline to fail.

[-] mmddmm@lemm.ee 1 points 1 week ago

Failing your local compilation due to linter problems is just stupid.

Sending "temporary" changes into your CI pipeline isn't even stupid, it's borderline malicious.

[-] bleistift2@sopuli.xyz 1 points 1 week ago

Sending “temporary” changes into your CI pipeline isn’t even stupid, it’s borderline malicious.

No? “Hey customer, I’ve deployed the changes you requested to the staging area. Is this what you had in mind? Keep in mind it only looks good and isn’t fully functional yet.”

[-] thequickben@lemm.ee 3 points 2 weeks ago

During code review, we reject PR’s with commented out code. Problem solved.

[-] CaptDust@sh.itjust.works 2 points 2 weeks ago

Honestly I'll disable linting across entire files during these kinds of refactors because it's annoying having build output littered with unused imports and format warnings while I'm still working on a solution. Requires some extra diligence to re-enable and clean up before pushing though.