Performance on opnsense is fine for anything you'll be doing at home, so I wouldn't factor that into your choice.

Features on opnsense are probably better, just due to all the packages you can install.

Do you prefer being 100% in a CLI all the time? If not I'd say opnsense, the GUI certainly makes things a lot easier when you're not fully familiar with something and spending every day interacting with it.

Never used VyOS so can't help there. I do use OpnSense, TP-Link Omada EAP-650's (with an isolated vLAN for the guest network) multiple vLAN's for cameras, iot, management, Trusted devices, and DMZ, along with Wireguard for remote access and since my ISP only gives me an IPv4 address I use a Wireguard tunnel to Route64 for IPv6 connectivity, a cellular connection for backup internet connectivity, CrowdSec, Intrusion Detection, Caddy, and UnboundDNS.

I used multiple different Router OS' since around 2005 and settled on OpnSense years ago. I stick around because there is rarely an issue and the reporting system makes it easy to visually spot issues.

I would start with opnsense as the router and then maybe play with VyOS in a VM to see if you want to switch down the road.

Both are just abstractions over primatives and services find in the underlying operating system.

Moving to just native of or nftables and running your firewall like a server has been on of my best moves. You will learn a tone more, have a lot more flexibility and overall o think it’s a much better experience.

I am a traditional network engineer as well (learned Juno’s/Cisco/etc). Ansible is a good way to do “commits” and config management.

Opensense is often bound by single-core operations depending on where a network packet may plumb itself through the kernel. A great example is any PPPoE connections on the base OS BSD. Vyos doesn’t have these same limitations since it’s minted on Linux - which supports traffic steering.

Really though, IaC for vyos has always been rock solid. Even though the persistent config in Opnsense is cool, adding new features or configs can be a bit of a pain in the ass

VyOS for performance but if you don't use a network device CLI regularly and it's for home use OPNsense.

OPNsense comes with a lot of pretty sane defaults for a gateway/firewall, VyOS you really do everything from scratch, as it's more geared towards enterprise or service provider.

VyOS does do well as a gateway/firewall and there is a lot you can install to extend features for stuff like what OPNsense has to the point that I have had 0 things I couldn't do when I migrated a few years ago.