20
What does your merge/code review process look like?
(beehaw.org)
All things programming and coding related. Subcommunity of Technology.
This community's icon was made by Aaron Schneider, under the CC-BY-NC-SA 4.0 license.
I work on an old monolithic system (20 years ish). It's a case management system. We've been through many iterations of our workflow over the years I've worked there. Our current workflow is,
The obvious down side to this way of working is that the product owners might have quite a few features to test if there is a hotfix, and other features have been merged since deploy. This has almost never been an issue though. We almost always deploy the very latest version on Wednesdays, and if there is a major issue, it's usually discovered and reported before 11 am on Thursday. So the number of other features which have found their way into the code is usually 1 or 2 at the most. Each feature is usually quite small in scope, so it's actually worked quite well for us.
How many developers do you have that you have to disable merging? Or is it more a safety-net?
Purely a safety net to avoid mistakes.
Merging straight from feature -> master is gutsy
Well. I told a slight lie. We go against develop. However, builds are created from develop. So we don't actually use main anymore. We used to, but our workflow changed over time untill we got to the point were we didn't use main anymore. I'm not even sure what we would use it for if we'd tried.