395

Rule (lemmy.blahaj.zone)

submitted 3 months ago by Persona3Reload to c/196

56 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[-] FiskFisk33@startrek.website 14 points 3 months ago

oh of course there is

https://www.npmjs.com/package/is-even

(do take a look at the download stats)

[-] FJW@discuss.tchncs.de 13 points 3 months ago* (last edited 3 months ago)

And that isn’t even the worst thing about it…

The implementation looks like this:

function isEven(i) {
  return !isOdd(i);
};

And yes, is-odd is a dependency that in turn depends on is-number…

[-] Micromot@feddit.org 8 points 3 months ago* (last edited 3 months ago)

Can't you just

If (number % 2 == 0){return true}

[-] blackn1ght@feddit.uk 12 points 3 months ago

return number % 2 === 0

[-] Micromot@feddit.org 1 points 3 months ago

Yeah, that's even simpler

[-] drake@lemmy.sdf.org 6 points 3 months ago

but what if number isn’t an integer, or even a number at all? This code, and the improved code shared by the other user, could cause major problems under those conditions. Really, what you would want, is to validate that number is actually an integer before performing the modulo, and if it isn’t, you want to throw an exception, because something has gone wrong.

That’s exactly what that NPM module does. And this is why it’s not a bad thing to use packages/modules for even very simple tasks, because they help to prevent us from making silly mistakes.