I think bitwarden fills all of your requirements.

Online password manager GTFO never ever doing that.

I use password safe desinged by Bruce Schneier, it's legit AF, https://pwsafe.org/

I like the Password for Nextcloud app. I self-host mine, but I think there might be Nextcloud instances that you can access. It is encrypted, and has an app for smartphones.

Bitwarden. Either selfhosted or the official

As others say, Bitwarden checks all of those boxes, and KeepassXC technically doesn't fit the "not self hosted" requirement, but you can store your database file in any cloud storage you want.

Bitwarden. Definitely recommended.

Bitwarden, no question

My brain. Comes up with the whackiest excuses for why this-and-that password would be a great choice and how easy it would be to remember, only to later explain to me rationally why it was the wrong choice and how I should've known I'd forget it. Then again, that's just extra security. If it's only stored in my internal memory and even I can't remember it, no one else is getting in for sure.

You can use SafeInCloud.

Used to love LastPass, then it charge expansive for pc and android multi device. I'm too looking for better pm.

I've been using keepass for 10+ years now. I store it on a USB that is only connected to the internet when I plug it in.

I use a mixture of Bitwarden and KeepassXC.

BW for most uses KP for things I only want local copies of ^^