78
How I got robbed of my first kernel contribution
(ariel-miculas.github.io)
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
this post was submitted on 27 Sep 2023
78 points (100.0% liked)
Programming
17025 readers
60 users here now
Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!
Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.
Hope you enjoy the instance!
Rules
Rules
- Follow the programming.dev instance rules
- Keep content related to programming in some way
- If you're posting long videos try to add in some form of tldr for those who don't want to watch videos
Wormhole
Follow the wormhole through a path of communities !webdev@programming.dev
founded 1 year ago
MODERATORS
Somebody is pretty salty for no good reason. The maintainers own patch is nicer code than the suggested patch - and the change is small enough that there just isn't anything available to guide the reporter to a better solution without wasting everyone's time.
I'd probably have added a thanks for debugging effort into the commit message myself - but "please accept my patch because I want to have code in the kernel" is a very stupid thing to say, and the maintainer offering a suitable problem to fix is more than I'd have done in that situation.
Unfortunately I don't have my original patch, because I only sent that to the Linux security mailing list. I don't think it's a stupid thing to want to have code in the kernel, especially after spending all my time debugging this issue. The fix was trivial once I've pointed to the exact place where the buffer overflow happened and I should have received credit for all my effort.
The way that you jumped straight onto broadcasting drama when your very first Linux kernel patch stumbled on the code review stage is a major red flag.
I would hate to work with you because I would feel that I would be risking being subjected to a very public character attack each time I had to review one of your patches.
I'm not broadcasting drama, I'm sharing my side of the story on my personal blog and distribute it to other social media platforms.
The patch didn't stumble on the code review stage, the PowerPC maintainer didn't want to accept patches from me and implemented his own fix.
Why would you hate people who would describe their interactions with you? The only reason I see is that you would hate how you've dealt with them.