72
you are viewing a single comment's thread
view the rest of the comments
[-] ProfessorScience@lemmy.world 12 points 3 weeks ago

Another option is to disable the warning locally [...] But this is compiler-specific and noisy. It also does not explain the real issue to anyone reading the code.

I don't understand this logic. Surely disabling the warning is directly explaining the actual issue, that the code emits a false positive warning for specific compilers and conditions? That the false_but_compiler_does_not_know_it_ thing is apparently the better way to convey what's going on seems kind of ridiculous.

[-] QuizzaciousOtter@lemmy.dbzer0.com 19 points 3 weeks ago

You could say that the current way is so unclear that the guy had to write a 2 thousand word essay to explain it.

[-] Venator@lemmy.nz 2 points 3 weeks ago* (last edited 3 weeks ago)

My guess would be they didn't like how verbose it was to supress the warning, or maybe they have a coding standard not to suppress warnings, and this was a workaround for that ๐Ÿ˜…

[-] Venator@lemmy.nz 3 points 3 weeks ago* (last edited 3 weeks ago)

actually not sure, as they do use #pragma GCC diagnostic ignored in a couple of places :

https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/win32/headless.c#L14

https://github.com/git/git/blob/8d96f09e9245ddf80c1981476fcbac8c4bb4125f/compat/regex/regex.c#L20

but apparently that disables it for everything after that line in the file though:

https://stackoverflow.com/questions/48426484/concise-way-to-disable-specific-warning-instances-in-clang#comment83878587_48426846

I think the second answer on that stackoverflow post might be better than false_but_the_compiler_does_not_know_it_ though...

[-] UnrepentantAlgebra@lemmy.world 2 points 3 weeks ago

My thought was that they may have to disable it differently for each compiler which might not be pretty, but yeah seems much easier to just do that as needed than to bend over backwards to look clever AND introduce unnecessary runtime effects at the same time.

this post was submitted on 20 Jun 2026
72 points (100.0% liked)

Technology

86419 readers
2686 users here now

This is a most excellent place for technology news and articles.


Our Rules


  1. Follow the lemmy.world rules.
  2. Only tech related news or articles.
  3. Be excellent to each other!
  4. Mod approved content bots can post up to 10 articles per day.
  5. Threads asking for personal tech support may be deleted.
  6. Politics threads may be removed.
  7. No memes allowed as posts, OK to post as comments.
  8. Only approved bots from the list below, this includes using AI responses and summaries. To ask if your bot can be added please contact a mod.
  9. Check for duplicates before posting, duplicates may be removed
  10. Accounts 7 days and younger will have their posts automatically removed.

Approved Bots


founded 3 years ago
MODERATORS