There's no point switching if you are using either of these two, so I'd just keep 1Password.

I just use firefox to remember my passwords

is there an advantage to switching to some third party app like bitwarden?

I feel like firefox is good enough and very easy to view/manage my passwords, but open to arguments why others are worth switching to

Bitwarden is very good, but if you are already comfortable with 1Password I don't think it is worth the switch. A lot of people (myself included) just recently switched from LastPass to Bitwarden due to LPs issues and breaches. But 1Password is still very solid and highly recommended.

I’ve been using Bitwarden for years now, and I really enjoy the seamless experience across platforms. I use Windows at work, Mac/Linux/Windows at home, I also have an iPhone, iPad, Android tablets, and a Chromebook. Bitwarden works great everywhere. I originally chose it because it’s open source so I could host it myself if I wanted to.

I actually pay for Premium ($10/year) because I wanted to use FIDO hardware keys, but you also get 1GB for encrypted file attachments, which is handy.

BitWarden does everything I want, so I have a hard time considering paying far more for 1Password which does the same thing.

I used LastPass Families for a few years, switched to 1Password for one year, and am now on Bitwarden. For me, it was the native MacOS app, so I can auto-fill apps besides just the browser (e.g. game and productivity software logins).